Document agentless Feature Flags delivery for Node.js#38231
Document agentless Feature Flags delivery for Node.js#38231leoromanovsky wants to merge 17 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
|
/review |
There was a problem hiding this comment.
🤖 Automated review by Claude. AI-generated; verify before acting.
Style and consistency findings only — no blockers. New page is well-structured and adds needed content. Main issues: inconsistent capitalization of the product name Remote Configuration in several headings, capitalization of "agentless" in headings, an em-dash formatting mismatch, one ambiguous reference to a future release, and a potentially confusing "Node.js 5.116.0" (this is a dd-trace version, not a Node.js runtime version).
Reviewed 558b4e2bd7793fe98b55094028af52db9c25b5d9 — workflow run
|
/review |
There was a problem hiding this comment.
🤖 Automated review by Claude. AI-generated; verify before acting.
Content is well-structured and clearly explains the new agentless delivery mode. A few small issues: two unused reference-link definitions, one hyphenation inconsistency with feature_flags/_index.md, and a couple of clarity nits.
Reviewed b18c59f489aadfdff1a4e279836605130e5dc967 — workflow run
|
Opened DOCS-15171 to follow up with editorial review. |
aarsilv
left a comment
There was a problem hiding this comment.
Approving with some minor suggestions about changes that happened while pairing. I'll submit a commit that updates.
@aarsilv I wrote this document taking into account two commits now in review and the decisions I made with Ruben assuming they would land and are part of the specification. Please take a read of them and review whether the documentation still matches. |
Document that the SDK sends the DD-API-KEY header to custom endpoints and that HTTP is permitted only for loopback hosts, matching shipped dd-trace 5.116.0/6.5.0 behavior. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Restores content/en/feature_flags/concepts/configuration_sources.md and content/en/feature_flags/server/nodejs.md to their state before a45a054. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Exciting new content, thanks @leoromanovsky for adding it! In addition to some line-edit suggestions, I think we could reorder the sections on the new Configuration Sources page for a clearer information architecture.
Because there are two major config source options, I'd expect them to be on more equal footing (even if one is default in some cases). But Remote Config is buried under "Advanced configuration," which also has agentless stuff mixed in, too. Here's a possible reorg, to have two major sections for the config options, and another section grouping topics that are common to both config options:
Server SDK Configuration Sources - overview
- Choose a configuration source
- Use agentless delivery (fka "Get started with agentless")
- Configure agentless delivery
- Use a custom agentless endpoint
- Migrate an existing Remote Configuration setup
- Use Agent Remote Configuration
- Advanced configuration
- Enable or disable flags
- Activation and billing
- Configuration precedence
Let me know if you think this would work, or if we should organize in a different direction.
Co-authored-by: Joe Peeples <joe.peeples@datadoghq.com>
Co-authored-by: Joe Peeples <joe.peeples@datadoghq.com>
Co-authored-by: Joe Peeples <joe.peeples@datadoghq.com>
…tless-feature-flags-docs # Conflicts: # config/_default/menus/main.en.yaml
Motivation
The upcoming Node.js Feature Flags releases add a Datadog-managed CDN configuration source that does not require a Datadog Agent. The documentation currently presents Agent Remote Configuration as the server SDK delivery path and describes no-Agent serverless delivery as unsupported.
Customers need the new default explained before adopting the releases, including exact minimum versions and the initial limitation that no-Agent deployments do not deliver exposure or aggregate
flagevaluationevents.Related implementation: DataDog/dd-trace-js#9397
Changes
5.116.0and Node.js v66.5.0.flagevaluationevent delivery.Input needed from reviewers
*** Presenting the information in parallel with RC and the organization is the principal help needed.**